Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charger Auth state: Add some more warning logging #682

Merged
merged 1 commit into from
May 13, 2024

Conversation

corneliusclaussen
Copy link
Contributor

Describe your changes

Charger can get stuck in WaitingForAuth state if e.g. PP signal reading fails or no energy is available for DC mode. This PR adds warning log output to see the reason in the log file.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@corneliusclaussen corneliusclaussen force-pushed the feature/charger-authstate-add-warnings branch from 3e3fb5b to e62f4c7 Compare May 13, 2024 07:28
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@corneliusclaussen corneliusclaussen merged commit 43cccb6 into main May 13, 2024
4 of 5 checks passed
@corneliusclaussen corneliusclaussen deleted the feature/charger-authstate-add-warnings branch May 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants